Re: [PATCH v4 2/2] leds: lm3601x: Introduce the lm3601x LED driver

[Pavel Machek]

Hi!

> >> Plus, removing the driver is not a command to disable the LED anyway.
> > 
> > True but you don't want to leave any LEDs in the on state without a driver to support it.
> > This could burn out the LED or the board if left on on max brightness
> 
> I disagree, we should not try to decide what the user wants here. We
> should only do what we are instructed to do, which for remove() is to
> cleanup what probe has done so the driver can be removed w/o leaking
> memory or device state.

We normally powerdown on rmmod. We should do that here, too.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature