Re: [PATCH v5 1/2] dt: bindings: lm3601x: Introduce the lm3601x driver

[Pavel Machek]

Hi!

> Introduce the device tree bindings for the lm3601x
> family of LED torch, flash and IR drivers.
> 
> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>

Better, thanks.
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3601x.txt
> @@ -0,0 +1,50 @@
> +* Texas Instruments - lm3601x Single-LED Flash Driver

Ok, so is it single-LED driver, or can it driver ir & white LEDs at
the same time?

> +Example:
> +led-controller@64 {
> +	compatible = "ti,lm36010";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	reg = <0x64>;
> +
> +	led@0 {
> +		reg = <0>;
> +		label = "white:torch";
> +		led-max-microamp = <10000>;
> +	};
> +
> +	led@1 {
> +		reg = <1>;
> +		label = "white:flash";
> +		flash-max-microamp = <10000>;
> +		flash-max-timeout-us = <800>;
> +	};

Is this realistic config? I'd expect flash to use more power than
torch, and would expect longer timeout than 0.8msec.

Also.. if this is physically one white LED, it should not be
spread over reg = <0> and reg = <1>...

Best regards,
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature