Re: [RFC] vfs: skip extra attributes check on removal for symlinks

From: Al Viro
Date: Thu May 10 2018 - 16:48:19 EST


On Thu, Apr 26, 2018 at 04:46:39PM -0700, Luis R. Rodriguez wrote:

> Since we cannot set these attributes we should special-case the
> immutable/append on delete for symlinks, this would be consistent with
> what we *do* allow on Linux for all filesystems.

Er... So why not simply sanity-check it in places that set it on
inodes? If anything, I would suggest
* converting all places that set those in ->i_flags to
inode_set_flags()
* making inode_set_flags() check and return an error on
that...