Re: [PATCH][next] net: aquantia: fix unsigned numvecs comparison with less than zero

[David Miller]

From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 10 May 2018 13:52:01 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The comparison of numvecs < 0 is always false because numvecs is a u32
> and hence the error return from a failed call to pci_alloc_irq_vectores
> is never detected.  Fix this by using the signed int ret to handle the
> error return and assign numvecs to err.
> 
> Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
> 
> Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

This doesn't apply to net-next.