Re: [PATCH v4 6/7] ocxl: Add an IOCTL so userspace knows what OCXL features are available

[Michael Ellerman]

"Alastair D'Silva" <alastair@xxxxxxxxxxx> writes:

> diff --git a/include/uapi/misc/ocxl.h b/include/uapi/misc/ocxl.h
> index 8d2748e69c84..bb80f294b429 100644
> --- a/include/uapi/misc/ocxl.h
> +++ b/include/uapi/misc/ocxl.h
> @@ -72,5 +75,6 @@ struct ocxl_ioctl_irq_fd {
>  #define OCXL_IOCTL_IRQ_SET_FD	_IOW(OCXL_MAGIC, 0x13, struct ocxl_ioctl_irq_fd)
>  #define OCXL_IOCTL_GET_METADATA _IOR(OCXL_MAGIC, 0x14, struct ocxl_ioctl_metadata)
>  #define OCXL_IOCTL_ENABLE_P9_WAIT	_IOR(OCXL_MAGIC, 0x15, struct ocxl_ioctl_p9_wait)
> +#define OCXL_IOCTL_GET_FEATURES _IOR(OCXL_MAGIC, 0x16, struct ocxl_ioctl_platform)

I don't have ocxl_ioctl_platform ?

../include/uapi/misc/ocxl.h:78:56: error: invalid application of âsizeofâ to incomplete type âstruct ocxl_ioctl_platformâ
 #define OCXL_IOCTL_GET_FEATURES _IOR(OCXL_MAGIC, 0x16, struct ocxl_ioctl_platform)
                                                        ^
../include/uapi/asm-generic/ioctl.h:73:5: note: in definition of macro â_IOCâ
   ((size) << _IOC_SIZESHIFT))
     ^~~~
../include/uapi/asm-generic/ioctl.h:86:56: note: in expansion of macro â_IOC_TYPECHECKâ
 #define _IOR(type,nr,size) _IOC(_IOC_READ,(type),(nr),(_IOC_TYPECHECK(size)))
                                                        ^~~~~~~~~~~~~~
../include/uapi/misc/ocxl.h:78:33: note: in expansion of macro â_IORâ
 #define OCXL_IOCTL_GET_FEATURES _IOR(OCXL_MAGIC, 0x16, struct ocxl_ioctl_platform)
                                 ^~~~
../drivers/misc/ocxl/file.c:262:7: note: in expansion of macro âOCXL_IOCTL_GET_FEATURESâ
  case OCXL_IOCTL_GET_FEATURES:
       ^~~~~~~~~~~~~~~~~~~~~~~

cheers