Re: [PATCH] lib/test_bitmap.c: Fix bitmap optimisation tests to report errors correctly

From: Michael Ellerman
Date: Fri May 11 2018 - 09:47:23 EST


Kees Cook <keescook@xxxxxxxxxxxx> writes:

> On Wed, May 9, 2018 at 4:43 AM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
>> From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>>
>> I had neglected to increment the error counter when the tests failed,
>> which made the tests noisy when they fail, but not actually return an
>> error code.
>>
>> Reported-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>> Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>> Fixes: 3cc78125a081 ("lib/test_bitmap.c: add optimisation tests")
>> Cc: stable@xxxxxxxxxxxxxxx # v4.13+
>> Tested-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>
> FWIW:
>
> Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Thanks.

cheers