Re: [PATCH] selftests: futex: delete RUN_TESTS and EMIT_TESTS overrides

From: Shuah Khan
Date: Fri May 11 2018 - 11:25:40 EST


On 05/11/2018 09:13 AM, Darren Hart wrote:
> On Wed, May 02, 2018 at 03:18:45PM -0600, Shuah Khan (Samsung OSG) wrote:
>> Delete RUN_TESTS and EMIT_TESTS overrides and use common defines in
>> lib.mk. Common defines work just fine and there is no need to define
>> custom overrides.
>>
>> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@xxxxxxxxxx>
>
> I was concerned because this override was a deliberate decision made in:
>
> 9705315b7562 selftests/futex: Update Makefile to use lib.mk

Yes I had the same concern.
>
> But reviewing lib.mk today, the RUN_TESTS and EMIT_TESTS perform the same
> function running TEST_PROGS.
>
> Reviewed-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>
>

Thanks. Yes I was surprised as well. I ran a few times to make sure. :)

-- Shuah