Re: [PATCH v4] dax: Change return type to vm_fault_t

From: Dan Williams
Date: Fri May 11 2018 - 12:34:43 EST


On Fri, May 11, 2018 at 9:34 AM, Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
>
> Commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Previously vm_insert_mixed() returns err which driver
> mapped into VM_FAULT_* type. The new function
> vmf_insert_mixed() will replace this inefficiency by
> returning VM_FAULT_* type.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
> Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> ---
> v2: Modified the change log
>
> v3: Updated the change log and
> added Ross in review list
>
> v4: Addressed David's comment.
> Changes in huge_memory.c put
> together in a single patch that
> it is bisectable in furture

Thanks, I'll carry this in the nvdimm tree since it collides with some
work-in progress development.