RE: [PATCH 3/9] soc: fsl: set rcpm bit for FTM

[Leo Li]

> -----Original Message-----
> From: Yinbo Zhu [mailto:yinbo.zhu@xxxxxxx]
> Sent: Thursday, May 10, 2018 10:35 PM
> To: Yinbo Zhu <yinbo.zhu@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> Mark Rutland <mark.rutland@xxxxxxx>; Catalin Marinas )
> <catalin.marinas@xxxxxxx>; Will Deacon ) <will.deacon@xxxxxxx>;
> Lorenzo Pieralisi ) <lorenzo.pieralisi@xxxxxxx>; Leo Li <leoyang.li@xxxxxxx>
> Cc: Xiaobo Xie <xiaobo.xie@xxxxxxx>; Ran Wang <ran.wang_1@xxxxxxx>;
> Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Thomas Gleixner
> <tglx@xxxxxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Madalin-cristian
> Bucur <madalin.bucur@xxxxxxx>; Z.q. Hou <zhiqiang.hou@xxxxxxx>; Jerry
> Huang <jerry.huang@xxxxxxx>; M.h. Lian <minghuan.lian@xxxxxxx>;
> Qiang Zhao <qiang.zhao@xxxxxxx>; Fabio Estevam
> <fabio.estevam@xxxxxxx>; Jiaheng Fan <jiaheng.fan@xxxxxxx>; Po Liu
> <po.liu@xxxxxxx>; Nipun Gupta <nipun.gupta@xxxxxxx>; Horia Geantă
> <horia.geanta@xxxxxxx>; Priyanka Jain <priyanka.jain@xxxxxxx>; Sumit
> Garg <sumit.garg@xxxxxxx>; costi <constantin.tudor@xxxxxxxxxxxxx>;
> Bogdan Purcareata <bogdan.purcareata@xxxxxxx>; Meng Yi
> <meng.yi@xxxxxxx>; Wang Dongsheng <dongsheng.wang@xxxxxxx>; open
> list:CLOCKSOURCE, CLOCKEVENT DRIVERS <linux-kernel@xxxxxxxxxxxxxxx>;
> open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@xxxxxxxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; open
> list:FREESCALE SOC DRIVERS <linuxppc-dev@xxxxxxxxxxxxxxxx>; Andy Tang
> <andy.tang@xxxxxxx>; Ying Zhang <ying.zhang22455@xxxxxxx>
> Subject: [PATCH 3/9] soc: fsl: set rcpm bit for FTM
> 
> From: Zhang Ying-22455 <ying.zhang22455@xxxxxxx>
> 
> Set RCPM for FTM when using FTM as wakeup source. Because the RCPM
> module of each platform has different big-end and little-end mode, there
> need to set RCPM depending on the platform.
> 
> Signed-off-by: Zhang Ying-22455 <ying.zhang22455@xxxxxxx>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@xxxxxxx>
> ---
>  .../devicetree/bindings/timer/fsl,ftm-timer.txt    |    7 ++
>  drivers/soc/fsl/layerscape/ftm_alarm.c             |   92 ++++++++++++++++++-
>  2 files changed, 94 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> index aa8c402..15ead58 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/fsl,ftm-timer.txt
> @@ -3,6 +3,13 @@ Freescale FlexTimer Module (FTM) Timer  Required
> properties:
> 
>  - compatible : should be "fsl,ftm-timer"

Hi Yingbo,

This is a change that breaks backward compatibility and not acceptable.

> + Possible compatibles for ARM:
> +     "fsl,ls1012a-ftm"
> +     "fsl,ls1021a-ftm"
> +     "fsl,ls1043a-ftm"
> +     "fsl,ls1046a-ftm"
> +     "fsl,ls1088a-ftm"
> +     "fsl,ls208xa-ftm"
>  - reg : Specifies base physical address and size of the register sets for the
>    clock event device and clock source device.
>  - interrupts : Should be the clock event device interrupt.
> diff --git a/drivers/soc/fsl/layerscape/ftm_alarm.c
> b/drivers/soc/fsl/layerscape/ftm_alarm.c
> index 6f9882f..811dcfa 100644
> --- a/drivers/soc/fsl/layerscape/ftm_alarm.c
> +++ b/drivers/soc/fsl/layerscape/ftm_alarm.c

There is no such file in the mainline kernel.  So it looks like the patch set is based on some internal git repo instead of the upstream Linux kernel.  This kind of patches shouldn't be sent to the upstream mailing list for review.

Regards,
Leo