Re: [PATCH v2] mm: Change return type to vm_fault_t

From: Matthew Wilcox
Date: Fri May 11 2018 - 14:16:04 EST


On Fri, May 11, 2018 at 11:36:39PM +0530, Souptick Joarder wrote:
> mm/hugetlb.c | 2 +-
> mm/mmap.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)

Don't we also need to convert include/linux/mm_types.h:

@@ -621,7 +621,7 @@ struct vm_special_mapping {
* If non-NULL, then this is called to resolve page faults
* on the special mapping. If used, .pages is not checked.
*/
- int (*fault)(const struct vm_special_mapping *sm,
+ vm_fault_t (*fault)(const struct vm_special_mapping *sm,
struct vm_area_struct *vma,
struct vm_fault *vmf);

or are you leaving that for a later patch?