Re: [PATCH 2/6] x86/intel_rdt/mba_sc: Enable/disable MBA software controller

[Thomas Gleixner]

On Fri, 20 Apr 2018, Vikas Shivappa wrote:
> +/*
> + * Enable or disable the MBA software controller
> + * which helps user specify bandwidth in MBps.
> + * MBA software controller is supported only if
> + * MBM is supported and MBA is in linear scale.
> + */
> +static int set_mba_sc(bool mba_sc)
> +{
> +	struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_MBA];
> +
> +	if (!is_mbm_enabled() || !is_mba_linear() ||
> +	    mba_sc == is_mba_sc(r))
> +		return -1;

Please use a proper return value as this gets propagated.

Thanks,

	tglx