Re: [RFC v2 3/4] ext4: add verifier check for symlink with append/immutable flags

From: Theodore Y. Ts'o
Date: Sun May 13 2018 - 16:51:57 EST

On Fri, May 11, 2018 at 11:12:18PM +0200, Jan Kara wrote:
> On Thu 10-05-18 16:13:58, Luis R. Rodriguez wrote:
> > The Linux VFS does not allow a way to set append/immuttable
> > attributes to symlinks, this is just not possible. If this is
> > detected inform the user as the filesystem must be corrupted.
> >
> > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx>
> Looks good to me. You can add:
> Reviewed-by: Jan Kara <jack@xxxxxxx>

Applied into the ext4 tree after verifying that e2fsck already handles
this case:

% e2fsck -fy /tmp/foo.img
e2fsck 1.44.1 (24-Mar-2018)
Pass 1: Checking inodes, blocks, and sizes
Special (device/socket/fifo/symlink) file (inode 13) has immutable
or append-only flag set. Clear? yes

(The btrfs and xfs maintainers might want to make a similar check
before accepting their respective patches.)

- Ted