Re: [PATCH] staging: speakup: Fix coding style

From: Joe Perches
Date: Sun May 13 2018 - 17:49:16 EST


On Sun, 2018-05-13 at 11:38 +0200, Samuel Thibault wrote:
[]
> @@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
> char spk_str_caps_start[MAXVARLEN + 1] = "\0";
> char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
> char spk_str_pause[MAXVARLEN + 1] = "\0";
> -bool spk_paused = 0;
> +bool spk_paused;
> const struct st_bits_data spk_punc_info[] = {
> {"none", "", 0},
> {"some", "/$%&@", SOME},
> @@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
> /* Speakup output, discard */
> return;
> speakup_date(vc);
> - if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
> - {
> + if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
> synth_printf("%s", spk_str_pause);
> spk_paused = 1;

probably nice to change the assignments of
spk_paused to true&false too