Re: [RFC PATCH -tip 2/4] kprobes: Remove jprobe generic code

From: Masami Hiramatsu
Date: Sun May 13 2018 - 20:03:49 EST


On Sun, 13 May 2018 21:55:38 +0200 (CEST)
Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> On Tue, 8 May 2018, Masami Hiramatsu wrote:
>
> > Remove jprobe arch independent generic code
> > from kernel/kprobes.c.
>
> # git grep register_jprobes
> include/linux/kprobes.h:static inline int register_jprobes(struct jprobe **jps, int num)
> include/linux/kprobes.h:static inline void unregister_jprobes(struct jprobe **jps, int num)
> kernel/test_kprobes.c: ret = register_jprobes(jps, 2);
> kernel/test_kprobes.c: pr_err("register_jprobes returned %d\n", ret);
> kernel/test_kprobes.c: unregister_jprobes(jps, 2);
>
> You forgot to remove a few things ...

Ah, thoes are already disabled (with #if 0) but it is better to remove it first.

Thanks!

>
> Thanks,
>
> tglx


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>