Re: [PATCH 15/17] efi/x86: Ignore unrealistically large option roms

From: Ingo Molnar
Date: Mon May 14 2018 - 02:41:00 EST



* Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:

> + /*
> + * Some firmwares contain EFI function pointers at the place where the
> + * romimage and romsize fields are supposed to be. Typically the EFI
> + * code is mapped at high addresses, translating to an unrealistically
> + * large romsize. The UEFI spec limits the size of option ROMs to 16
> + * MiB so we reject any roms over 16 MiB in size to catch this.
> + */

JFYI, I fixed this:

s/Some firmwares contain
/Some firmware images contain

and:

s/roms
/ROMs

(Looks good otherwise, no need to resend.)

Thanks,

Ingo