Re: [PATCH 05/19 v3] regulator: max77686: Pass descriptor instead of GPIO number

From: Krzysztof Kozlowski
Date: Mon May 14 2018 - 05:28:24 EST


On Mon, May 14, 2018 at 10:06 AM, Linus Walleij
<linus.walleij@xxxxxxxxxx> wrote:
> Instead of passing a global GPIO number, pass a descriptor looked
> up from the device tree configuration node.
>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v2->v3:
> - Name the regulator "max77686-regulator"
> - Set the regulator to NULL on erroneous lookup, restoring the
> old init data lookup behaviour.
> ChangeLog v1->v2:
> - Rebase the patch on the other changes.
> ---
> drivers/regulator/max77686-regulator.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Tested on Odroid U3 (with max77686 although not using any GPIOs for
regulators, so at least default paths are not broken):
Tested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof