Re: [PATCH] PM / core: refactor PM_OPS initializers

[kbuild test robot]

Hi Andrzej,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pm/linux-next]
[also build test WARNING on v4.17-rc5 next-20180511]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Andrzej-Hajda/PM-core-refactor-PM_OPS-initializers/20180514-172201
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: openrisc-or1ksim_defconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=openrisc 

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:23:0,
                    from include/linux/cdev.h:8,
                    from include/linux/tty_driver.h:245,
                    from include/linux/tty.h:9,
                    from include/linux/serial_core.h:29,
                    from drivers/tty/serial/8250/8250_of.c:11:
   drivers/tty/serial/8250/8250_of.c:293:44: error: 'of_serial_suspend' undeclared here (not in a function)
    static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
                                               ^
   include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR'
    #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL)
                                                              ^~~
   include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
     SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_of.c:293:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
    static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
           ^~~~~~~~~~~~~~~~~
   drivers/tty/serial/8250/8250_of.c:293:63: error: 'of_serial_resume' undeclared here (not in a function)
    static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
                                                                  ^
   include/linux/pm.h:316:59: note: in definition of macro 'PM_SLEEP_PTR'
    #define PM_SLEEP_PTR(ptr) (IS_ENABLED(CONFIG_PM_SLEEP) ? (ptr) : NULL)
                                                              ^~~
   include/linux/pm.h:354:2: note: in expansion of macro 'SET_SYSTEM_SLEEP_PM_OPS'
     SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
     ^~~~~~~~~~~~~~~~~~~~~~~
>> drivers/tty/serial/8250/8250_of.c:293:8: note: in expansion of macro 'SIMPLE_DEV_PM_OPS'
    static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
           ^~~~~~~~~~~~~~~~~

vim +/SIMPLE_DEV_PM_OPS +293 drivers/tty/serial/8250/8250_of.c

8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  276  
aa42db44f drivers/tty/serial/8250/8250_of.c Arnd Bergmann        2017-01-25  277  static int of_serial_resume(struct device *dev)
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  278  {
aa42db44f drivers/tty/serial/8250/8250_of.c Arnd Bergmann        2017-01-25  279  	struct of_serial_info *info = dev_get_drvdata(dev);
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  280  	struct uart_8250_port *port8250 = serial8250_get_port(info->line);
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  281  	struct uart_port *port = &port8250->port;
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  282  
a2d23edae drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16  283  	if (!uart_console(port) || console_suspend_enabled) {
a2d23edae drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16  284  		pm_runtime_get_sync(dev);
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  285  		clk_prepare_enable(info->clk);
a2d23edae drivers/tty/serial/8250/8250_of.c Franklin S Cooper Jr 2017-08-16  286  	}
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  287  
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  288  	serial8250_resume_port(info->line);
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  289  
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  290  	return 0;
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  291  }
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  292  #endif
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11 @293  static SIMPLE_DEV_PM_OPS(of_serial_pm_ops, of_serial_suspend, of_serial_resume);
8ad3b1352 drivers/tty/serial/of_serial.c    Jingchang Lu         2014-11-11  294  

:::::: The code at line 293 was first introduced by commit
:::::: 8ad3b1352693972b737607c7b9c89b56d45fea9b serial: of-serial: add PM suspend/resume support

:::::: TO: Jingchang Lu <jingchang.lu@xxxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip