Re: [FAIL bisect] Sound card probe error

From: Marek Szyprowski
Date: Mon May 14 2018 - 08:36:34 EST

Hi Krzysztof,

On 2018-05-14 14:29, Krzysztof Kozlowski wrote:
> On Mon, May 14, 2018 at 2:22 PM, Sylwester Nawrocki
> <s.nawrocki@xxxxxxxxxxx> wrote:
>> Hi,
>> On 05/14/2018 12:17 PM, Krzysztof Kozlowski wrote:
>>> Bisected to:
>>> 8c123c14bbba4add148536b6d47a9226deda2f7a is the first bad commit
>>> commit 8c123c14bbba4add148536b6d47a9226deda2f7a
>>> Author: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>> Date: Thu Apr 26 10:53:06 2018 +0200
>>> driver core: Respect all error codes from dev_pm_domain_attach()
>>> The limitation of being able to check only for -EPROBE_DEFER from
>>> dev_pm_domain_attach() has been removed. Hence let's respect all error
>>> codes and bail out accordingly.
>>> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
>>> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>> The DRM driver creates the HDMI codec but its registration fails, due
>> to some missing clocks. The clock are missing because the exynos5-subcmu
>> driver probing fails.
>> [ 0.678578] exynos5-subcmu: probe of GSC failed with error -17
>> [ 0.679250] exynos5-subcmu: probe of MFC failed with error -17
>> [ 0.679992] exynos5-subcmu: probe of DISP failed with error -17
>> The exynos5-subcmu driver before registering platform device makes
>> of_genpd_add_device() call, so in platform_drv_probe() dev_pm_domain_attach()
>> call will fail, as dev->pm_domain is already set. Previously the error
>> was masked by code removed in the above commit and platform_drv_probe()
>> was could complete successfully.
> Thanks Sylwester!
> Ah, I missed these messages because I was looking at err dmesg level
> (and for some reason these are warn). Anyway do you have any thoughts
> how is it connected with missing Odroid XU3 sound card and max98090
> codec?

Odroid XU3 sound card driver is waiting for HDMI codec, which is being
by Exynos DRM HDMI driver, which was deferred by lack of clocks.

Best regards
Marek Szyprowski, PhD
Samsung R&D Institute Poland