Re: [PATCH 2/6] staging: android: Clean up license identifiers

From: Greg Kroah-Hartman
Date: Mon May 14 2018 - 09:51:54 EST


On Mon, May 14, 2018 at 04:29:45PM +0300, Dan Carpenter wrote:
> On Sun, May 06, 2018 at 06:13:24PM -0700, Nathan Chancellor wrote:
> > Add the identifiers when missing and fix the ones already present
> > according to checkpatch.pl.
> >
> > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> > ---
> > drivers/staging/android/ashmem.h | 6 +-----
> > drivers/staging/android/uapi/ashmem.h | 6 +-----
> > drivers/staging/android/uapi/vsoc_shm.h | 10 +---------
> > drivers/staging/android/vsoc.c | 11 +----------
> > 4 files changed, 4 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/staging/android/ashmem.h b/drivers/staging/android/ashmem.h
> > index 60d7208f110a..1a478173cd21 100644
> > --- a/drivers/staging/android/ashmem.h
> > +++ b/drivers/staging/android/ashmem.h
> > @@ -1,13 +1,9 @@
> > -// SPDX-License-Identifier: (GPL-2.0 OR Apache-2.0)
> > +/* SPDX-License-Identifier: GPL-2.0 OR Apache-2.0 */
>
>
> // was correct for SPDX headers.

Not for .h files, as per the documentation. Sorry, I got this wrong the
first time around.

greg k-h