Re: [RFC][PATCH 07/10] tracing: Have zero size length in filter logic be full string

[Steven Rostedt]

On Sat, 12 May 2018 20:32:18 +0200
Yann Ylavic <ylavic.dev@xxxxxxxxx> wrote:

> On Fri, May 11, 2018 at 9:49 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> []
> >
> >  static int regex_match_front(char *str, struct regex *r, int len)
> >  {
> > -       if (len < r->len)
> > +       if (len && len < r->len)
> >                 return 0;
> >
> > -       if (strncmp(str, r->pattern, r->len) == 0)
> > -               return 1;
> > -       return 0;
> > +       return strncmp(str, r->pattern, len) == 0;  
> 
> strncmp(..., r->len) still?
> 
> >  }  

Ouch! Yes! I have no idea how I did that :-/

Thanks for pointing that out.

-- Steve