Re: [PATCH v2 0/2] mm: PAGE_KERNEL_* fallbacks

From: Greg KH
Date: Mon May 14 2018 - 10:24:20 EST


On Thu, May 10, 2018 at 05:15:20PM +0000, Luis R. Rodriguez wrote:
> On Thu, May 10, 2018 at 08:07:33AM +0200, Greg KH wrote:
> > On Wed, May 09, 2018 at 06:44:45PM -0700, Luis R. Rodriguez wrote:
> > > While dusting out the firmware loader closet I spotted a PAGE_KERNEL_*
> > > fallback hack. This hurts my eyes, and it should also be blinding
> > > others. Turns out we have other PAGE_KERNEL_* fallback hacks in
> > > other places.
> > >
> > > This moves them to asm-generic, and keeps track of architectures which
> > > need some love or review. At least 0-day was happy with the changes.
> > >
> > > Matthew Wilcox did put together a PAGE_KERNEL_RO patch for ia64, that
> > > needs review and testing, and if it goes well it should be merged.
> > >
> > > Luis R. Rodriguez (2):
> > > mm: provide a fallback for PAGE_KERNEL_RO for architectures
> > > mm: provide a fallback for PAGE_KERNEL_EXEC for architectures
> > >
> > > drivers/base/firmware_loader/fallback.c | 5 ----
> > > include/asm-generic/pgtable.h | 36 +++++++++++++++++++++++++
> > > mm/nommu.c | 4 ---
> > > mm/vmalloc.c | 4 ---
> > > 4 files changed, 36 insertions(+), 13 deletions(-)
> >
> > No list of changes that happened from v1? :(
>
> Didn't know you'd want it for such simple patch set, but I'll provide one for v3 and
> also list the changes in v2.

Nothing is "trivial" really, and given the huge rate of patch
submissions, how is anyone supposed to remember what you did in the last
one?

thanks,

greg k-h