Re: [PATCH v2] i2c: i801: fix unused-function warning

[Andy Shevchenko]

On Mon, May 14, 2018 at 12:33 PM, Anders Roxell
<anders.roxell@xxxxxxxxxx> wrote:
> With CONFIG_PM, we get a harmless build warning:
> drivers/i2c/busses/i2c-i801.c:1723:12: warning: âi801_resumeâ defined but not used [-Wunused-function]
>  static int i801_resume(struct device *dev)
>             ^~~~~~~~~~~
> drivers/i2c/busses/i2c-i801.c:1714:12: warning: âi801_suspendâ defined but not used [-Wunused-function]
>  static int i801_suspend(struct device *dev)
>             ^~~~~~~~~~~~

> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
>  static int i801_suspend(struct device *dev)

The better pattern is to get rid of ugly ifdef and supply
__maybe_unused annotation to each function in question.


-- 
With Best Regards,
Andy Shevchenko