Re: [PATCH v5 2/2] leds: lm3601x: Introduce the lm3601x LED driver

From: Andy Shevchenko
Date: Mon May 14 2018 - 15:50:00 EST

On Mon, May 14, 2018 at 10:40 PM, Dan Murphy <dmurphy@xxxxxx> wrote:
> On 05/11/2018 06:56 AM, Dan Murphy wrote:

>>>> + ret = of_property_read_string(led->strobe_node, "label", &name);

>>>> + ret = of_property_read_u32(led->strobe_node,

>>>> + ret = of_property_read_u32(led->strobe_node,

>>> Common LED bindings state that flash-max-microamp and
>>> flash-max-timeout-us properties are mandatory.
>> OK.
> OK I looked at the max776973 driver and well if the flash-max-microamp and
> flash-max-timeout-us nodes are missing it sets a default value for each if the
> node is not present.
> So should we remove this code from the Max77693 driver too and fail probe as being asked
> in this driver?

I would also add that using device_property_*() API is much better
then using OF specific one. It will help IoT / DIY entusiasts use them
on non-DT platforms.

With Best Regards,
Andy Shevchenko