Re: linux-next: build warning after merge of the rdma tree

From: Steve Wise
Date: Mon May 14 2018 - 16:29:43 EST




On 5/14/2018 1:09 PM, Steve Wise wrote:
>
> On 5/14/2018 1:03 PM, Jason Gunthorpe wrote:
>> On Mon, May 07, 2018 at 09:44:54AM +1000, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the rdma tree, today's linux-next build (x86_64
>>> allmodconfig) produced this warning:
>>>
>>> drivers/infiniband/hw/cxgb4/restrack.c: In function 'fill_res_qp_entry':
>>> drivers/infiniband/hw/cxgb4/restrack.c:140:6: warning: 'last_rq_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>> if (rdma_nl_put_driver_u32(msg, "idx", idx))
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/infiniband/hw/cxgb4/restrack.c:180:20: note: 'last_rq_idx' was declared here
>>> u16 first_rq_idx, last_rq_idx;
>>> ^~~~~~~~~~~
>>> drivers/infiniband/hw/cxgb4/restrack.c:140:6: warning: 'first_rq_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>> if (rdma_nl_put_driver_u32(msg, "idx", idx))
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/infiniband/hw/cxgb4/restrack.c:180:6: note: 'first_rq_idx' was declared here
>>> u16 first_rq_idx, last_rq_idx;
>>> ^~~~~~~~~~~~
>>> drivers/infiniband/hw/cxgb4/restrack.c:228:6: warning: 'last_sq_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>> if (fill_swsqes(msg, &wq.sq, first_sq_idx, fsp, last_sq_idx, lsp))
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/infiniband/hw/cxgb4/restrack.c:228:6: warning: 'first_sq_idx' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>>
>>> Introduced by commit
>>>
>>> 056f9c7f39bf ("iw_cxgb4: dump detailed driver-specific QP information")
>>>
>> SteveW, is there a patch to fix this that I'm missing?
>>
>> Thanks,
>> Jason
> Hey Jason,Â
>
> I'll send you one shortly.Â
>
> Steve.
>

Posted:Â https://patchwork.kernel.org/patch/10399081/

Steve.