Re: [PATCH ghak81 RFC V2 3/5] audit: use inline function to get audit context
From: Richard Guy Briggs
Date: Mon May 14 2018 - 23:28:47 EST
On 2018-05-14 23:05, Richard Guy Briggs wrote:
> On 2018-05-14 17:44, Paul Moore wrote:
> > On Sat, May 12, 2018 at 9:58 PM, Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
> > > Recognizing that the audit context is an internal audit value, use an
> > > access function to retrieve the audit context pointer for the task
> > > rather than reaching directly into the task struct to get it.
> > >
> > > Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> > > ---
> > > include/linux/audit.h | 14 ++++++--
> > > include/net/xfrm.h | 2 +-
> > > kernel/audit.c | 6 ++--
> > > kernel/audit_watch.c | 2 +-
> > > kernel/auditsc.c | 64 +++++++++++++++++-------------------
> > > net/bridge/netfilter/ebtables.c | 2 +-
> > > net/core/dev.c | 2 +-
> > > net/netfilter/x_tables.c | 2 +-
> > > net/netlabel/netlabel_user.c | 2 +-
> > > security/integrity/ima/ima_api.c | 2 +-
> > > security/integrity/integrity_audit.c | 2 +-
> > > security/lsm_audit.c | 2 +-
> > > security/selinux/hooks.c | 4 +--
> > > security/selinux/selinuxfs.c | 6 ++--
> > > security/selinux/ss/services.c | 12 +++----
> > > 15 files changed, 64 insertions(+), 60 deletions(-)
> >
> > Merged, but there was some fuzz due to the missing 1/5 patch and a
> > handfull of checkpatch.pl fixes. Please take a look at the commit in
> > the audit/next branch and if anything looks awry please send a patch
> > to fix it.
>
> Some of that fuzz was due to the two patches (ghak46/47) that went
> through the xelinux tree... There will be a merge conflict.
>
> Otherwise, looks ok.
Spoke too soon, missed one from the new seccomp actions_logged...
Patch pending...
> > paul moore
>
> - RGB
- RGB
--
Richard Guy Briggs <rgb@xxxxxxxxxx>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635