Re: [RFC PATCH v2 2/2] locking/percpu-rwsem: Mark rwsem as non-spinnable in percpu_rwsem_release()

From: Amir Goldstein
Date: Tue May 15 2018 - 03:04:25 EST


On Tue, May 15, 2018 at 8:42 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote:
> On Mon, May 14, 2018 at 10:31 PM, Waiman Long <longman@xxxxxxxxxx> wrote:
>> The percpu_rwsem_release() is called when the ownership of the embedded
>> rwsem is to be transferred to another task. The new owner, however, may
>> take a while to get the ownership of the lock via percpu_rwsem_acquire().
>> During that period, the rwsem is now marked as writer-owned with no
>> optimistic spinning.
>>
>
> Waiman,
>
> Thanks for the fix. I will test it soon.
>
> For this commit message I suggest that you add parts of the reproducer
> found here:
> https://marc.info/?l=linux-fsdevel&m=152622016219975&w=2
>

fsfreeze is happy with these changes.

You may add:
Tested-by: Amir Goldstein <amir73il@xxxxxxxxx>

Thanks,
Amir.