Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct
From: Andy Shevchenko
Date: Tue May 15 2018 - 14:54:08 EST
On Thu, May 10, 2018 at 11:59 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> On Thu, May 3, 2018 at 9:34 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> Starting from the commit 0d0443288f22 the new function has been
>>> introduced which takes struct task_struct as a parameter. Though,
>>> compiler doesn't know where to get information about it at this stage.
>>>
>>> Add missed declaration of struct task_struct to satisfy compiler.
>>>
>>> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
>>> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>>> Cc: James Morris <james.l.morris@xxxxxxxxxx>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>
>> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>> I'm not sure who should carry this. You're welcome to put it in your tree?
>
> I haven't seen this show up in linux-next. Andy will you be taking it?
Will be in next next.
--
With Best Regards,
Andy Shevchenko