Re: [PATCH v2] gpu: drm: armada: Adding new typedef vm_fault_t
From: Souptick Joarder
Date: Wed May 16 2018 - 00:35:15 EST
On Fri, May 11, 2018 at 2:52 PM, Russell King - ARM Linux
<linux@xxxxxxxxxxxxxxx> wrote:
> On Thu, May 10, 2018 at 08:34:48PM +0530, Souptick Joarder wrote:
>> Use new return type vm_fault_t for fault handler in
>> struct vm_operations_struct. For now, this is just
>> documenting that the function returns a VM_FAULT
>> value rather than an errno. Once all instances are
>> converted, vm_fault_t will become a distinct type.
>>
>> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>>
>> Previously vm_insert_pfn() returns err which driver
>> mapped into VM_FAULT_* type. The new function
>> vmf_insert_pfn() will replace this inefficiency by
>> returning VM_FAULT_* type.
>>
>> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
>> Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
>
> Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
>
> Thanks.
If no further comment, we would like to get this patch in queue
for 4.18.