Re: [PATCH v10 02/27] clk: davinci: da850-pll: change PLL0 to CLK_OF_DECLARE

[Sekhar Nori]

On Tuesday 15 May 2018 09:12 PM, David Lechner wrote:
> On 05/15/2018 08:31 AM, Sekhar Nori wrote:
>> On Wednesday 09 May 2018 10:55 PM, David Lechner wrote:
>>> +void of_da850_pll0_init(struct device_node *node)
>>> Â {
>>> -ÂÂÂ return of_davinci_pll_init(dev, dev->of_node, &da850_pll0_info,
>>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &da850_pll0_obsclk_info,
>>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ da850_pll0_sysclk_info, 7, base, cfgchip);
>>> +ÂÂÂ void __iomem *base;
>>> +ÂÂÂ struct regmap *cfgchip;
>>> +
>>> +ÂÂÂ base = of_iomap(node, 0);
>>> +ÂÂÂ if (!base) {
>>> +ÂÂÂÂÂÂÂ pr_err("%s: ioremap failed\n", __func__);
>>> +ÂÂÂÂÂÂÂ return;
>>> +ÂÂÂ }
>>> +
>>> +ÂÂÂ cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
> 
> In your previous review, you pointed out that the error did not need to
> be handled here because it is handled later in davinci_pll_clk_register().>
> We get a warning there because cfgchip is only needed for unlocking the
> PLL for CPU frequency scaling and is not critical for operation of the
> clocks.

Oops, forgot about that :)

Reviewed-by: Sekhar Nori <nsekhar@xxxxxx>

Thanks,
Sekhar