Re: [PATCH] f2fs: Fix deadlock in shutdown ioctl

From: Sahitya Tummala
Date: Wed May 16 2018 - 02:59:29 EST


On Wed, May 16, 2018 at 02:48:42PM +0800, Chao Yu wrote:
> >
> > Thanks, I thought about it too but then I checked that XFS shutdown ioctl is
> > not taking any lock for this ioctl. Hence, I followed the same in F2FS.
> > Do you know why XFS is not taking any lock?
>
> I don't know. :(

No problem :)

>
> > Is it really needed in shutdown ioctl?
>
> IMO, yes, we should keep freeze and remount be aware of the shutdown operation.

Thanks for your inputs. I will send the updated patch set.

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.