RE: [PATCH v8 01/12] perf/x86/intel/pt: Move Intel-PT MSRs bit definitions to a public header

From: Kang, Luwei
Date: Wed May 16 2018 - 05:10:24 EST


> > From: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
> >
> > Intel Processor Trace virtualization enabling in KVM guest need to
> > access these MSRs bit definitions, so move them to public header file
> > msr-index.h.
> > @@ -115,6 +148,7 @@
> > #define MSR_IA32_RTIT_ADDR2_B 0x00000585
> > #define MSR_IA32_RTIT_ADDR3_A 0x00000586
> > #define MSR_IA32_RTIT_ADDR3_B 0x00000587
> > +#define MSR_IA32_RTIT_ADDR_RANGE 4
>
> This one wasn't there before, so belongs in a different patch.

What about move this definition to "arch/x86/include/asm/intel_pt.h " and be added in patch 8 (implementation of context switch).

Thanks,
Luwei Kang

>
> Regards,
> --
> Alex