Re: [PATCH 01/14] orangefs: don't return errno values from ->fault

From: Matthew Wilcox
Date: Wed May 16 2018 - 06:46:15 EST


On Wed, May 16, 2018 at 07:43:35AM +0200, Christoph Hellwig wrote:
> + rc = orangefs_inode_getattr(file->f_mapping->host, 0, 1, STATX_SIZE);
> if (rc) {
> gossip_err("%s: orangefs_inode_getattr failed, "
> "rc:%d:.\n", __func__, rc);
> - return rc;
> + return VM_FAULT_SIGBUS;

Nope. orangefs_inode_getattr can return -ENOMEM.

> }
> return filemap_fault(vmf);
> }
> --
> 2.17.0
>