Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge

From: Timur Tabi
Date: Wed May 16 2018 - 13:59:21 EST


On 05/16/2018 01:23 PM, Sinan Kaya wrote:
+ win_start = window->res->start - window->offset;

Can you guarantee that window->res->start is always >= window->offset?

+ win_size = window->res->end - window->res->start + 1;

Use resource_size() instead.

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.