Re: [PATCH] bpf: add __printf verification to bpf_verifier_vlog

From: Daniel Borkmann
Date: Wed May 16 2018 - 18:27:21 EST


On 05/16/2018 10:27 PM, Mathieu Malaterre wrote:
> __printf is useful to verify format and arguments. âbpf_verifier_vlogâ
> function is used twice in verifier.c in both cases the caller function
> already uses the __printf gcc attribute.
>
> Remove the following warning, triggered with W=1:
>
> kernel/bpf/verifier.c:176:2: warning: function might be possible candidate for âgnu_printfâ format attribute [-Wsuggest-attribute=format]
>
> Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>

Looks good, applied to bpf-next, thanks Mathieu!