Re: [PATCH 4.4 159/190] ipsec: check return value of skb_to_sgvec always

From: Greg Kroah-Hartman
Date: Thu May 17 2018 - 04:13:28 EST


On Wed, May 16, 2018 at 02:58:02PM +0100, Ben Hutchings wrote:
> On Wed, 2018-04-11 at 20:36 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Jason A. Donenfeld <Jason@xxxxxxxxx>
> >
> > commit 3f29770723fe498a5c5f57c3a31a996ebdde03e1 upstream.
> [...]
>
> This leaves the error paths in esp{4,6}.c leaking memory; fixed
> upstream by:
>
> commit e6194923237f3952b955c343b65b211f36bce01c
> Author: Steffen Klassert <steffen.klassert@xxxxxxxxxxx>
> Date:   Thu Jul 13 09:13:30 2017 +0200
>
>     esp: Fix memleaks on error paths.

Really? That patch doesn't apply at all. It looks like this patch
fixes things that happened after the above patch.

Or am I confused?

thanks,

greg k-h