Re: [PATCH v2 1/1] s390: vfio-ccw: push down unsupported IDA check

[Cornelia Huck]

On Thu, 17 May 2018 09:09:25 +0800
Dong Jia Shi <bjsdjshi@xxxxxxxxxxxxx> wrote:

> * Halil Pasic <pasic@xxxxxxxxxxxxx> [2018-05-16 19:33:42 +0200]:
> 
> Nitpick for Subject prefix (?):
> s/s390: vfio-ccw:/vfio: ccw:/

Trivial to fix up while applying.

> 
> > There is at least one relevant guest OS that doesn't set the IDA flags in
> > the ORB as we would like them, but never uses any IDA. So instead of
> > saying -EOPNOTSUPP when observing an ORB, such that a channel program
> > specified by it could be a not supported one, let us say -EOPNOTSUPP only
> > if the channel program is a not supported one.
> > 
> > Of course, the real solution would be doing proper translation for all
> > IDA. This is possible, but given the current code not straight forward.
> > 
> > Signed-off-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
> > Tested-by: Jason J. Herne <jjherne@xxxxxxxxxxxxx>
> > ---
> > ---  
> Leftover?

git am will drop this anyway :)

> 
> >  drivers/s390/cio/vfio_ccw_cp.c | 19 ++++++++++++++++---
> >  1 file changed, 16 insertions(+), 3 deletions(-)
> >   
> 
> Reviewed-by: Dong Jia Shi <bjsdjshi@xxxxxxxxxxxxx>

Thanks!