Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On

From: Logan Gunthorpe
Date: Thu May 17 2018 - 10:51:36 EST


Thanks for your hard work on this Doug!

On 17/05/18 06:00 AM, dmeyer@xxxxxxxxxx wrote:

> + if (pci_enable_device(pdev)) {
> + dev_err(&pdev->dev, "Cannot enable Switchtec device\n");
> + return;
> + }

I suspect we should probably cass pci_disable_device() before leaving
this function so it's in the same state we started. Just like we unmap
the mmio.

Logan