Re: [PATCH v6 6/9] dt-bindings: counter: Document stm32 quadrature encoder

[Rob Herring]

On Wed, May 16, 2018 at 12:51 PM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:
> From: Benjamin Gaignard <benjamin.gaignard@xxxxxx>

v6? Where's v1-v5?

> Add bindings for STM32 Timer quadrature encoder.
> It is a sub-node of STM32 Timer which implement the
> counter part of the hardware.
>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx>
> ---
>  .../bindings/counter/stm32-timer-cnt.txt      | 26 +++++++++++++++++++
>  .../devicetree/bindings/mfd/stm32-timers.txt  |  7 +++++
>  2 files changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt
>
> diff --git a/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt
> new file mode 100644
> index 000000000000..377728128bef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/stm32-timer-cnt.txt
> @@ -0,0 +1,26 @@
> +STMicroelectronics STM32 Timer quadrature encoder
> +
> +STM32 Timer provides quadrature encoder counter mode to detect

'mode' does not sound like a sub-block of the timers block.

> +angular position and direction of rotary elements,
> +from IN1 and IN2 input signals.
> +
> +Must be a sub-node of an STM32 Timer device tree node.
> +See ../mfd/stm32-timers.txt for details about the parent node.
> +
> +Required properties:
> +- compatible:          Must be "st,stm32-timer-counter".
> +- pinctrl-names:       Set to "default".
> +- pinctrl-0:           List of phandles pointing to pin configuration nodes,
> +                       to set IN1/IN2 pins in mode of operation for Low-Power
> +                       Timer input on external pin.
> +
> +Example:
> +       timers@40010000  {
> +               compatible = "st,stm32-timers";
> +               ...
> +               counter {
> +                       compatible = "st,stm32-timer-counter";

Is there only 1? How is the counter addressed?

> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&tim1_in_pins>;
> +               };
> +       };