Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

From: Eric W. Biederman
Date: Thu May 17 2018 - 14:18:43 EST


Christoph Hellwig <hch@xxxxxx> writes:

> On Thu, May 17, 2018 at 12:28:01AM -0500, Eric W. Biederman wrote:
>> > struct pid_namespace *proc_pid_namespace(struct inode *inode)
>> > {
>> > // maybe warn on for s_magic not on procfs??
>> > return inode->i_sb->s_fs_info;
>> > }
>>
>> That should work. Ideally out of line for the proc_fs.h version.
>> Basically it should be a cousin of PDE_DATA.
>
> The version in Al's tree is inline and without the warning as
> I didn't want to drag in the magic.h include. Please look at it for
> additional comments, I can send incremental fixups if needed.

Sounds good.

Eric