Re: [PATCH] perf annotate: Support multiple events without group

From: Jiri Olsa
Date: Thu May 17 2018 - 15:31:08 EST


On Thu, May 17, 2018 at 01:27:50PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, May 10, 2018 at 09:59:22PM +0800, Jin Yao escreveu:
> > See example,
> >
> > perf record -e cycles,branches ./div
> > perf annotate main --stdio or
> > perf annotate main --stdio2 or
> > perf annotate main
> >
> > The "perf annotate" should show both cycles and branches on the
> > left side, but actually it only shows one event cycles.
> >
> > It works with events group like:
> > perf record -e "{cycles,branches}" ./div
> >
> > It should work too even without group.
>
> Humm, I think that this should be done the way it is for perf report,
> i.e. you select the group output by using --group, no?
>
> Jiri, isn't that how it is done in 'perf report' for non-explicit
> groups?

yep, if there's no event group, the --group will enable the group
output in report.. sounds ok to follow this also in annotate

'perf report' TUI offers list of events to choose from
and the --stdio version prints report for each event
annotate could do the same

jirka