Re: [PATCHv2][SMB3] Add kernel trace support

From: Ronnie Sahlberg
Date: Thu May 17 2018 - 22:31:49 EST


Very nice.

Acked-by: Ronnie Sahlberg <lsahlber@xxxxxxxxxx>

Possibly change the output from
pid=6633 tid=0x0 sid=0x0 cmd=0 mid=0
to
cmd=0 mid=0 pid=6633 tid=0x0 sid=0x0

just to make it easier for human-searching. I think the cmd will be useful much more often than pid/tid/sid
and this would make it easier to look for as all cmd= entries will be aligned to the same column.



----- Original Message -----
From: "Steve French" <smfrench@xxxxxxxxx>
To: "CIFS" <linux-cifs@xxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "samba-technical" <samba-technical@xxxxxxxxxxxxxxx>, "linux-fsdevel" <linux-fsdevel@xxxxxxxxxxxxxxx>
Sent: Friday, 18 May, 2018 12:36:36 PM
Subject: [PATCHv2][SMB3] Add kernel trace support

Patch updated with additional tracepoint locations and some formatting
improvements. There are some obvious additional tracepoints that could
be added, but this should be a reasonable group to start with.