Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

[Roger Quadros]

On 18/05/18 10:47, Andrzej Hajda wrote:
> On 18.05.2018 09:38, Roger Quadros wrote:
>> On 18/05/18 08:39, Andrzej Hajda wrote:
>>> On 17.05.2018 18:06, kbuild test robot wrote:
>>>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>>>> Signed-off-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>>> It should be static of course, my bad.
>>>
>>> Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
>> I don't think we accept patches from robots, yet :)
> 
> What do you mean by 'we'? In case of whole kernel it is not true:
> 
> $ git log --author='kbuild test robot <fengguang.wu@xxxxxxxxx>'
> --oneline | wc -l
> 183

OK, then I'm wrong. Should have checked before commenting. Sorry about that.

> 
> Regards
> Andrzej
> 
>>
>>> Â--
>>> Regards
>>> Andrzej
>>>
>>>> ---
>>>>  drd.c |    2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>>>> index 2706824..218371f 100644
>>>> --- a/drivers/usb/dwc3/drd.c
>>>> +++ b/drivers/usb/dwc3/drd.c
>>>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>>>  	return NOTIFY_DONE;
>>>>  }
>>>>  
>>>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>>>  {
>>>>  	struct device *dev = dwc->dev;
>>>>  	struct device_node *np_phy, *np_conn;
>>>>
>>>>
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki