Re: [PATCH -resend 02/27] x86: assembly, use SYM_DATA for data

[Jiri Slaby]

On 05/15/2018, 08:39 AM, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> 
>>
>> * Jiri Slaby <jslaby@xxxxxxx> wrote:
>>
>>> We make proper use of SYM_DATA on global data instead of marking them as
>>> ENTRY. ENTRY is intended for functions and shall be paired with ENDPROC.
>>> ENTRY also aligns symbols which creates unnecessary holes here between
>>> data.
>>>
>>> ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64 is
>>> simply dropped, as these symbols are local only.
>>
>> Yeah, so this commit talks about ENTRY() and ENDPROC(), while the new methods are 
>> SYM_FUNC_START()/END().
> 
> BTW., I like the series otherwise: for example in my comment above I wrote up the 
> SYM_FUNC_START()/END() names from memory, without having to look up the 
> primitives.

Thanks, I am about to send v6 in a short while. It addresses the comments.

-- 
js
suse labs