Re: [PATCH v3] scripts/tags.sh: don't parse `ls` for $ALLSOURCE_ARCHS generation

[Joey Pabalinas]

On Fri, May 18, 2018 at 04:08:44PM +0900, Masahiro Yamada wrote:
> I do not like hard-coding the file(s) in arch/.
> 
> Don't you have an idea to list only directories?
> 'find -type d' or 'ls -F' or something?

How do you feel about the following?

>  # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH
>  if [ "${ALLSOURCE_ARCHS}" = "" ]; then
>          ALLSOURCE_ARCHS="${SRCARCH}"
>  elif [ "${ALLSOURCE_ARCHS}" = "all" ]; then
>          ALLSOURCE_ARCHS="$(cd "${tree}arch/" && find . -maxdepth 1 -type d | paste -sd' ')"
>          ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS//[.\/]}"
>  fi

If something like that if acceptable, I'll use that for the v4.

-- 
Cheers,
Joey Pabalinas

Attachment: signature.asc
Description: PGP signature