Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

[Ramon Fried]

On 17 May 2018 at 21:37, Jeff Johnson <jjohnson@xxxxxxxxxxxxxx> wrote:
> On 2018-05-17 04:32, Ramon Fried wrote:
>>
>> From: Eyal Ilsar <eilsar@xxxxxxxxxxxxxx>
>
> ...
>>
>> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn,
>> +                               struct ieee80211_vif *vif, void *ptt_msg,
>> size_t len,
>> +               void **ptt_rsp_msg)
>> +{
>> +       struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body;
>> +       int ret = 0;
>> +
>> +       mutex_lock(&wcn->hal_mutex);
>> +       p_msg_body = kmalloc(
>> +               sizeof(struct wcn36xx_hal_process_ptt_msg_req_msg) + len,
>> +               GFP_ATOMIC);
>
>
> NULL check required?
>
>> +       INIT_HAL_PTT_MSG(p_msg_body, len);
>> +

Thanks Jeff. will fix it and send again :)