Re: [PATCH] perf tests: Fix regex for record+probe_libc_inet_pton.sh
From: Thomas-Mich Richter
Date: Fri May 18 2018 - 06:13:41 EST
On 05/18/2018 12:29 PM, Sandipan Das wrote:
> Hi Thomas,
>
> On 05/18/2018 03:51 PM, Thomas-Mich Richter wrote:
> [...]
>>
>> This patch fails on s390. I used 4.17.0rc5 + fedora 27 and I get this output:
>>
>>
>> [root@p23lp27 perf]# ./perf test 59
>> 59: probe libc's inet_pton & backtrace it with ping : Ok
>> [root@p23lp27 linux]# cd ~/linux; patch -p1 < ../inet_pton1
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> patching file tools/perf/tests/shell/record+probe_libc_inet_pton.sh
>> [root@p23lp27 linux]# cd -;
>> [root@p23lp27 perf]# ./perf test 59
>> 59: probe libc's inet_pton & backtrace it with ping : FAILED!
>> [root@p23lp27 perf]#
>>
>> Debugging revealed this line as cause of failure:
>>
>>
>> FAIL: expected backtrace entry 2 "gaih_inet.*\+0x[[:xdigit:]]+[[:space:]]\(/usr/lib64/libc-2.26.so|inlined\)$" got "fdcb1 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)"
>>
>> Here is the output of the trace file
>>
>> [root@p23lp27 perf]# perf script
>> ping 87291 [001] 96936.231618: probe_libc:inet_pton: (3ff96342378)
>> 142378 __inet_pton (inlined)
>> fdcb1 gaih_inet.constprop.7 (/usr/lib64/libc-2.26.so)
>> 100189 __GI_getaddrinfo (inlined)
>> 398d main (/usr/bin/ping)
>> 2303d __libc_start_main (/usr/lib64/libc-2.26.so)
>> 457b [unknown] (/usr/bin/ping)
>>
>> [root@p23lp27 perf]#
>>
>> Hope this helps
>>
>
> Can you please apply these two patches as well and then re-test?
>
> [1] https://lkml.org/lkml/2018/5/17/112
> [2] https://lkml.org/lkml/2018/5/17/113
>
> - Sandipan
>
Ahhh, yes that helped. Must have missed it. Thanks for the pointer.
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
GeschÃftsfÃhrung: Dirk Wittkopp
Sitz der Gesellschaft: BÃblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294