Re: [PATCH 2/6] x86: bug: prevent gcc distortions

From: hpa
Date: Fri May 18 2018 - 14:45:41 EST


On May 18, 2018 12:36:20 PM PDT, Nadav Amit <namit@xxxxxxxxxx> wrote:
>hpa@xxxxxxxxx wrote:
>
>> On May 18, 2018 12:21:00 PM PDT, Linus Torvalds
><torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>> On Fri, May 18, 2018 at 12:18 PM Nadav Amit <namit@xxxxxxxxxx>
>wrote:
>>>
>>>> Gnu ASM manual says: "Each time you run as it assembles exactly one
>>> source
>>>> program. The source program is made up of one or more files.â
>>>
>>> Ok, that counts as documentation, although it's confusing as hell.
>Is
>>> it
>>> one source program or multiple files again? I see what they are
>trying
>>> to
>>> say, but it really could be phrased more clearly ;)
>>>
>>> Linus
>>
>> At least we have a solution!
>
>Thanks for all your help. I will try to do it over over the weekend.
>
>Funny, I see that this âtrickâ (-Wa,[filename.s]) is already being used
>to
>include arch/x86/boot/code16gcc.h so I feel âsaferâ to use it.
>
>Regards,
>Nadav

Oh. I don't remember when we did that... might even be my doing and then I just forgot about it :)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.