Re: [PATCH 5/6] x86: refcount: prevent gcc distortions

From: kbuild test robot
Date: Fri May 18 2018 - 23:32:43 EST


Hi Nadav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/auto-latest]
[also build test ERROR on v4.17-rc5 next-20180517]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Nadav-Amit/x86-objtool-use-asm-macro-for-better-compiler-decisions/20180519-045439
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

arch/x86/include/asm/refcount.h: Assembler messages:
>> arch/x86/include/asm/refcount.h:67: Error: too many positional arguments

vim +67 arch/x86/include/asm/refcount.h

63
64 static __always_inline void refcount_inc(refcount_t *r)
65 {
66 asm volatile(LOCK_PREFIX "incl %0\n\t"
> 67 "__REFCOUNT_CHECK_LT_ZERO %[counter]"
68 : [counter] "+m" (r->refs.counter)
69 : : "cc", "cx");
70 }
71

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip