Re: [PATCH V3 09/39] x86/intel_rdt: Enable setting of exclusive mode

[Thomas Gleixner]

On Wed, 25 Apr 2018, Reinette Chatre wrote:
> +/**
> + * rdtgroup_cbm_overlaps - Does CBM for intended closid overlap with other
> + * @r: Resource to which domain instance @d belongs.
> + * @d: The domain instance for which @closid is being tested.
> + * @cbm: Capacity bitmask being tested.
> + * @closid: Intended closid for @cbm.
> + * @exclusive: Only check if overlaps with exclusive resource groups
> + *
> + * Checks if provided @cbm intended to be used for @closid on domain
> + * @d overlaps with any other closids or other hardware usage associated
> + * with this domain. If @exclusive is true then only overlaps with
> + * resource groups in exclusive mode will be considered. If @exclusive
> + * is false then overlaps with any resource group or hardware entities
> + * will be considered.
> + *
> + * Return: 0 if CBM does not overlap, 1 if it does.
> + */
> +static int rdtgroup_cbm_overlaps(struct rdt_resource *r, struct rdt_domain *d,

I think this should be bool not int.

> +/**
> + * rdtgroup_mode_test_exclusive - Test if this resource group can be exclusive
> + *
> + * An exclusive resource group implies that there should be no sharing of
> + * its allocated resources. At the time this group is considered to be
> + * exclusive this test can determine if its current schemata supports this
> + * setting by testing for overlap with all other resource groups.
> + *
> + * Return: 1 if resource group can be exclusive, 0 if there is overlap
> + * with allocations of other resource groups and thus this resource group
> + * cannot be exclusive.
> + */
> +static int rdtgroup_mode_test_exclusive(struct rdtgroup *rdtgrp)

Ditto.

Thanks,

	tglx