Re: [PATCH v2] isdn: eicon: fix a missing-check bug

From: David Miller
Date: Sun May 20 2018 - 17:42:22 EST


From: Wenwen Wang <wang6495@xxxxxxx>
Date: Fri, 18 May 2018 16:33:47 -0500

> In divasmain.c, the function divas_write() firstly invokes the function
> diva_xdi_open_adapter() to open the adapter that matches with the adapter
> number provided by the user, and then invokes the function diva_xdi_write()
> to perform the write operation using the matched adapter. The two functions
> diva_xdi_open_adapter() and diva_xdi_write() are located in diva.c.

This doesn't even compile:

In file included from drivers/isdn/hardware/eicon/divasmain.c:30:
drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name ʽdiva_xdi_um_cfg_cmd_tʼ
int length, diva_xdi_um_cfg_cmd_t *msg,
^~~~~~~~~~~~~~~~~~~~~
drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name ʽdiva_xdi_um_cfg_cmd_tʼ
int length, diva_xdi_um_cfg_cmd_t *msg,
^~~~~~~~~~~~~~~~~~~~~